New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resolveConfig
to Node.js API
#5734
Conversation
Allows resolving the effective configuration for a given file, similar to --print-config on the CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adalinesimonian Great work! 👏🏼
I've suggested somes small refactoring ideas, but this PR mostly looks good to me. 👍🏼
@ybiquitous Resolved comments in dfca589, af61233, and 8d664ef. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found some typos, but LGTM! 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adalinesimonian Thanks for the quick fix! 😄
resolveConfig
to APIresolveConfig
to Node.js API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Closes #5723
Allows resolving the effective configuration for a given file, similar to
--print-config
on the CLI.